AnsweredAssumed Answered

AFDatabase IsDirty value is not as expected

Question asked by Robatjazi on Jul 4, 2019
Latest reply on Jul 9, 2019 by sraposo

Like • Show 0 Likes0
Comment • 15

Hi all,

I have a situation that IsDirty value is not right.

I just connect to PI and open a AF Database and then call CheckIn(). Before and after calling CheckIn() the IsDirty property of AFDatabae is true. I do not understand why. This is the definition of IsDirty: "Indicates whether there are objects in the AFDatabase that have been modified since the last save in to persistent storage".

I do not have any change on open database, Why IsDirty is true?

Using:

PI DATA Archive 2017 R2A

PI AF Service 2017 R2A

PI Asset Framework (AF) Client 2017 R2

No one else has this question

Outcomes

15 Replies

Eugene Lee Jul 5, 2019 5:09 AM
Mark Correct
Correct Answer

With AF Client version 2018 SP2, I get the expected behavior. You could try upgrading your AF Client to the latest version.
Like • Show 0 Likes0
Actions
- Robatjazi @ Eugene Lee on Jul 5, 2019 1:57 PM
  Mark Correct
  Correct Answer
  It is the same on 2018.
  
  I read the AFElement and convert it to a dto object.
  Also I read the AFElement's Analyses and this the spot causes dirty database. I do not know why id I do not read analyses then after CheckIn the status is not dirty.
  Like • Show 0 Likes0
  Actions
  - sraposo @ Robatjazi on Jul 5, 2019 2:09 PM
    Mark Correct
    Correct Answer
    Are you calling in CheckIn() on the AFDatabase object or AFElement?
    Like • Show 0 Likes0
    Actions
    - Robatjazi @ sraposo on Jul 5, 2019 2:34 PM
      Mark Correct
      Correct Answer
      On AFDatabase
      Like • Show 0 Likes0
      Actions
      - sraposo @ Robatjazi on Jul 5, 2019 2:58 PM
        Mark Correct
        Correct Answer
        Can you share your code ?
        Like • Show 0 Likes0
        Actions
        Robatjazi @ sraposo on Jul 5, 2019 4:25 PM
        Mark Correct
        Correct Answer
        PISystem pisystem = new PISystems()["xxx"]; pisystem.Connect(); AFDatabase database = pisystem.Databases["xxx"]; var id = Guid.Parse("xxx"); AFElement element = AFElement.FindElement(pisystem, id); AFAnalysis analysis; if (!element.Analyses.Contains("xxx")) { analysis = null; } analysis = element.Analyses["xxx"]; element.Delete(); if (database.IsDirty) { Console.WriteLine("Database is dirty."); } database.CheckIn(); if (database.IsDirty) { Console.WriteLine("AGAIN Database is dirty."); }
        
        After database.CheckIn() the IsDirty is true!
        But if I remove those line that read Analyses then IsDirty will be false after CheckIn
        Like • Show 0 Likes0
        Actions
        Rick Davin @ Robatjazi on Jul 5, 2019 4:10 PM
        Mark Correct
        Correct Answer
        The problem is a logic error in your code.
        
        Either you have over-obfuscated your code, or else you have 2 different variable references to an AFDatabase. One is named _database and the other is simply database. You check-in database but later check _database to see if it is dirty. It still thinks it is, and rightfully so since it is unaware of the check-in on database. Fix: use only 1 variable for the AFDatabase or else issue a _database.Refresh() before checking IsDirty after database was checked in. My recommendation would be to use ONE variable.
        Like • Show 0 Likes0
        Actions
        Robatjazi @ Rick Davin on Jul 5, 2019 4:27 PM
        Mark Correct
        Correct Answer
        Actually I have just one database variable. I edited here to make it simple and it was a mistake. My bad.
        I updated that mistake.
        Like • Show 0 Likes0
        Actions
        Rick Davin @ Robatjazi on Jul 5, 2019 5:20 PM
        Mark Correct
        Correct Answer
        Assuming your code is correct now, then it may be a bug in AF SDK. The issue is that when invoking the Analyses collection of an element, the analyses are cached in memory and this cache is independent from the database or element objects, and therefore unaware of when the check-in is performed. Thus a dirty copy in lingering in memory after you delete the primary referenced element and check-in the database.
        
        The current workaround should be to issue a database.Refresh(). Or another thing worth trying would be to set affected variables to null to remove lingering client-side references. That may be the real cause, since you are retaining references to these other variables.
        
        analysis = null; element.Delete(); element = null; database.CheckIn();
        
        I will check with our Assets developers to see if this is an intentional bug or an unknown one.
        
        Though you didn't ask, I think a section of your code can be simplified. Lines 06-11 could be reduced to a single line:
        
        AFAnalysis analysis = element.Analyses["xxx"];
        
        If there is no such analyses belonging to the element, a null is returned.
        Like • Show 0 Likes0
        Actions
        Robatjazi @ Rick Davin on Jul 5, 2019 5:42 PM
        Mark Correct
        Correct Answer
        I tried database.Refresh() and it did not work.
        
        Also set analysis to null, how it can affect as it is local variable?
        
        Like • Show 0 Likes0
        Actions
        Rick Davin @ Robatjazi on Jul 8, 2019 1:36 PM
        Mark Correct
        Correct Answer
        A local variable can affect things if it's keeping a reference open to something on a server. My wishful thinking for setting it to null would be that it would no longer contain a reference to an analysis in the cache (also local), in which case the cache would be cleared. Again, wishful thinking.
        
        Anyway, our developers have confirmed this is a bug and will be fixed in future releases of AF SDK.
        Like • Show 0 Likes0
        Actions
        Robatjazi @ Rick Davin on Jul 8, 2019 1:53 PM
        Mark Correct
        Correct Answer
        Thanks Rick.
        Like • Show 0 Likes0
        Actions
        sraposo @ Robatjazi on Jul 9, 2019 4:02 PM
        Mark Correct
        Correct Answer
        We made the work item externally available. It's resolved in 2018 SP2. Here is the link:
        https://customers.osisoft.com/s/knowledgearticle?knowledgeArticleUrl=1C2C0C2A-9D6A-5B85-3B93-1E3D649A3876
        Like • Show 0 Likes0
        Actions
sraposo Jul 5, 2019 12:43 PM
Mark Correct
Correct Answer
Hi Majid,

Did you check to see if other users may have objects checked out? You could use PI System Explorer. If you do Undo Check-Out, you can select Show All Users to see if anyone has anything checked out.

Hope this helps,
Seb
Like • Show 0 Likes0
Actions
- Robatjazi @ sraposo on Jul 5, 2019 1:54 PM
  Mark Correct
  Correct Answer
  Hi Seb,
  
  No, just one user is using AF.
  Like • Show 0 Likes0
  Actions

AFDatabase IsDirty value is not as expected

Outcomes

Related Content

Recommended Content